Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 6583 - cast() operation not fully specified #3502

Merged
merged 9 commits into from
Jan 31, 2023

Conversation

Robert21721
Copy link
Contributor

Added some information and examples about pointers and the casting process
https://issues.dlang.org/show_bug.cgi?id=6583

@dlang-bot
Copy link
Contributor

dlang-bot commented Jan 28, 2023

Thanks for your pull request and interest in making D better, @Robert21721! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
6583 normal cast() operation not fully specified

spec/expression.dd Outdated Show resolved Hide resolved
spec/expression.dd Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Jan 28, 2023

you need to reword the first commit message from "fixed ...." to "fix ...." so that the bot get triggered.

@Robert21721 Robert21721 changed the title Fixed issue 6583 - cast() operation not fully specified Fix issue 6583 - cast() operation not fully specified Jan 28, 2023
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the last suggestion, that has not worked, the PR looks formally OK to me however.

@Robert21721 Robert21721 changed the title Fix issue 6583 - cast() operation not fully specified Fix Issue 6583 - cast() operation not fully specified Jan 28, 2023
@RazvanN7
Copy link
Contributor

@Robert21721 changing the title of the PR is not going to trigger the bot. You need to add a commit (a.k.a git commit -m "Fix Issue 6583 - ...").

Copy link
Contributor

@RazvanN7 RazvanN7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not fully address the issue at hand. The following need to be treated for this PR to be accepted:

  • casting a pointer type to a basic type
  • casting a signed to an unsigned and vice-versa

As suggested in the issue, maybe these could be treated in related to what C does.

spec/expression.dd Outdated Show resolved Hide resolved
spec/expression.dd Show resolved Hide resolved
spec/expression.dd Show resolved Hide resolved
spec/expression.dd Outdated Show resolved Hide resolved
@Robert21721 Robert21721 requested review from RazvanN7 and removed request for andralex, WalterBright, mdparker and maxhaton January 30, 2023 13:25
spec/expression.dd Outdated Show resolved Hide resolved
Copy link
Contributor

@RazvanN7 RazvanN7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new try, unfortunately, we are not quite there.

Technical prose needs to be precise, concise and neutral.

spec/expression.dd Outdated Show resolved Hide resolved
spec/expression.dd Outdated Show resolved Hide resolved
spec/expression.dd Outdated Show resolved Hide resolved
spec/expression.dd Show resolved Hide resolved
spec/expression.dd Outdated Show resolved Hide resolved
spec/expression.dd Outdated Show resolved Hide resolved
@Robert21721 Robert21721 requested a review from RazvanN7 January 31, 2023 00:40
Copy link
Contributor

@RazvanN7 RazvanN7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there.

spec/expression.dd Outdated Show resolved Hide resolved
spec/expression.dd Outdated Show resolved Hide resolved
spec/expression.dd Outdated Show resolved Hide resolved
spec/expression.dd Outdated Show resolved Hide resolved
spec/expression.dd Outdated Show resolved Hide resolved
Copy link
Contributor

@RazvanN7 RazvanN7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash the commits and we are ready to go.

@RazvanN7 RazvanN7 merged commit a4e799b into dlang:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants