-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 6583 - cast() operation not fully specified #3502
Conversation
|
Thanks for your pull request and interest in making D better, @Robert21721! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
|
|
you need to reword the first commit message from "fixed ...." to "fix ...." so that the bot get triggered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the last suggestion, that has not worked, the PR looks formally OK to me however.
|
@Robert21721 changing the title of the PR is not going to trigger the bot. You need to add a commit (a.k.a git commit -m "Fix Issue 6583 - ..."). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not fully address the issue at hand. The following need to be treated for this PR to be accepted:
- casting a pointer type to a basic type
- casting a signed to an unsigned and vice-versa
As suggested in the issue, maybe these could be treated in related to what C does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new try, unfortunately, we are not quite there.
Technical prose needs to be precise, concise and neutral.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash the commits and we are ready to go.
Added some information and examples about pointers and the casting process
https://issues.dlang.org/show_bug.cgi?id=6583