Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Issue 22594 - Update "Interfacing to C" to include intptr_t and uintptr_t #3509

Closed
wants to merge 0 commits into from
Closed

Fixed Issue 22594 - Update "Interfacing to C" to include intptr_t and uintptr_t #3509

wants to merge 0 commits into from

Conversation

ioanavivi12
Copy link
Contributor

I added an extra row to include intptr_t and uintptr_t data types.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ioanavivi12! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 22594 enhancement Update "Interfacing to C" to include intptr_t and uintptr_t

maxhaton
maxhaton requested changes Feb 1, 2023
View reviewed changes
spec/interfaceToC.dd Outdated
@@ -152,6 +152,7 @@ $(H2 $(LNAME2 data_type_compat, Data Type Compatibility))

$(TROW3 core.stdc.config.c_long, long, long)
$(TROW3 core.stdc.config.c_ulong, unsigned long, unsigned long)
$(TROW3 core.stdc.stdint, intptr_t, uintptr_t)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The columns are for 32 and 64 bit so this isn't right I think.

Should be two rows, one for signed and unsigned (it's the same type for each column)

Also core.stdc.stdint.intptr_t rather than core.stdc.stdint

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it now. I hope it is ok.

@ioanavivi12 ioanavivi12 requested review from maxhaton and removed request for andralex, WalterBright and mdparker February 2, 2023 07:20
RazvanN7
RazvanN7 requested changes Feb 2, 2023
View reviewed changes
spec/interfaceToC.dd Outdated
@@ -152,6 +152,7 @@ $(H2 $(LNAME2 data_type_compat, Data Type Compatibility))

$(TROW3 core.stdc.config.c_long, long, long)
$(TROW3 core.stdc.config.c_ulong, unsigned long, unsigned long)
$(TROW2 core.stdc.stdint.intptr_t, intptr_t, $(D uintptr_t))
Copy link
Contributor

@RazvanN7 RazvanN7 Feb 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are putting both on the same row, but what is actually needed is:

 $(TROW3 core.stdc.stdint.intptr_t, intptr_t, intptr_t)
 $(TROW3 core.stdc.stdint.uintptr_t, uintptr_t, uintptr_t)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you still need to delete this row.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it, thank you. I hope it is ok now.

RazvanN7
RazvanN7 reviewed Feb 2, 2023
View reviewed changes
spec/interfaceToC.dd Outdated

$(TROW3PLUS long, long long, long, (or $(D long long)))
$(TROW3PLUS ulong, unsigned long long, unsigned long, (or $(D unsigned long long)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this deleted?

RazvanN7
RazvanN7 reviewed Feb 2, 2023
View reviewed changes
spec/interfaceToC.dd Outdated
@@ -412,3 +414,4 @@ Macros:
TROW3PLUS=$(TR3 $(TD $(D $1)), $(TD $(D $2)), $(TD $(D $3) $4))
TD2=$(MULTICOL_CELL 2, $0)
TITLE=Interfacing to C

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unrelated to this PR.

@RazvanN7
Copy link
Contributor

RazvanN7 commented Feb 2, 2023

Please squash commits.

@Geod24
Copy link
Member

Geod24 commented Feb 2, 2023

Please include the issue name as part of the commit title and PR title.
For people watching this repository, "Fix issue 22594" has no meaning, and they would like to know if they need to open the notification or not.

@ioanavivi12 ioanavivi12 changed the title Fix Issue 22594 Fixed Issue 22594 - Update "Interfacing to C" to include intptr_t and uintptr_t Feb 3, 2023
@ioanavivi12 ioanavivi12 closed this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RazvanN7 RazvanN7 RazvanN7 requested changes

@maxhaton maxhaton Awaiting requested review from maxhaton

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ioanavivi12 @dlang-bot @RazvanN7 @Geod24 @maxhaton