Fixed issue 18830 - document "new" with "scope" in @nogc Functions #3515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaresCon
requested review from
andralex,
WalterBright,
maxhaton and
mdparker
as code owners
|
Thanks for your pull request and interest in making D better, @RaresCon! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
|
RazvanN7
requested changes
Feb 2, 2023
spec/function.dd
Outdated
| @@ -3558,7 +3558,10 @@ $(H2 $(LNAME2 nogc-functions, No-GC Functions)) | |||
| $(LI $(DDSUBLINK spec/expression, AssocArrayLiteral, constructing an associative array)) | |||
| $(LI $(DDSUBLINK spec/expression, IndexExpression, indexing) an associative array | |||
| $(NOTE because it may throw $(D RangeError) if the specified key is not present)) | |||
| $(LI $(DDSUBLINK spec/expression, NewExpression, allocating an object with `new`) on the heap) | |||
| $(LI $(DDSUBLINK spec/expression, NewExpression, allocating an object with `new`) on the heap | |||
| $(NOTE `new` declarations of $(D class types) are | |||
There was a problem hiding this comment.
new declaration of $(D class types) in function scopes are [..]
|
Please use "Fix issue ..." in the commit message (not "Fixed") so that the bot picks this up. |
RazvanN7
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation for allowance of "new" in
@nogcfunctions.