Issue 20997 - Missing example of scope guard executing after return statement #3520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BVRazvan
requested review from
andralex,
WalterBright,
maxhaton and
mdparker
as code owners
|
Thanks for your pull request and interest in making D better, @BVRazvan! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
|
RazvanN7
requested changes
Feb 7, 2023
spec/statement.dd
Outdated
| ) | ||
|
|
||
| A return lies inside the scope of a function; therefore, a $(D scope()) | ||
| statement will be executed subsequently. |
There was a problem hiding this comment.
There's no need for this sentence.
There was a problem hiding this comment.
Changed it, please check.
spec/statement.dd
Outdated
| $(CONSOLE | ||
| Inside bar() | ||
| Inside foo() | ||
| ) |
There was a problem hiding this comment.
Please move this example so that it is grouped with the others.
There was a problem hiding this comment.
Moved it, please check.
BVRazvan
requested review from
RazvanN7
and removed request for
andralex,
WalterBright,
mdparker and
maxhaton
RazvanN7
approved these changes
Feb 7, 2023
|
Please squash commits. The git history seems to be messed up. |
BVRazvan
force-pushed
the
issue_20997
branch
2 times, most recently
from
411ce32
to
6aee44f
Compare
RazvanN7
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: https://issues.dlang.org/show_bug.cgi?id=20997
I added an example to clarify the order of execution when scope() statement interferes with return statement.