Skip to content

put predefined version identifiers into categories #4249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

put predefined version identifiers into categories #4249

merged 1 commit into from
Jun 20, 2025

Conversation

@WalterBright
Copy link
Member

@WalterBright WalterBright commented Jun 19, 2025

Adding a bit more structure helps with understanding them.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jun 19, 2025

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

rikkimax
rikkimax reviewed Jun 19, 2025
View reviewed changes
spec/version.dd Outdated
$(TROW $(ARGS $(D ELFv1)) , $(ARGS Elf version 1))
$(TROW $(ARGS $(D ELFv2)) , $(ARGS Elf version 2))

$(THEAD Miscellaneous)
Copy link
Contributor

@rikkimax rikkimax Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A title like code generation features might be better than just "misc"

Copy link
Member Author

@WalterBright WalterBright Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are rather generic

@ntrel
Copy link
Contributor

ntrel commented Jun 20, 2025

The trailing comma after each THEAD invocation is breaking the ddoc output:
https://dtest.dlang.io/artifact/website-07af77ef2c58ccf7eec5577ac1dbe7b6f115834f-a7c8b57019b09fdc2bc5219ab3a59987/web/spec/version.html#predefined-versions

I've fixed that in a PR to this PR:
WalterBright#2

It also changes the formatting to not use THEAD, which distinguishes the categories from the column headers.

@WalterBright
Copy link
Member Author

WalterBright commented Jun 20, 2025

@ntrel thank you, I have folded in your changes!

@thewilsonator thewilsonator merged commit ba00dac into dlang:master Jun 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikkimax rikkimax rikkimax left review comments

@thewilsonator thewilsonator thewilsonator approved these changes

@andralex andralex Awaiting requested review from andralex andralex is a code owner

@maxhaton maxhaton Awaiting requested review from maxhaton maxhaton is a code owner

@mdparker mdparker Awaiting requested review from mdparker mdparker is a code owner

Assignees

No one assigned

Labels

Easy Review Spec / content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@WalterBright @dlang-bot @ntrel @rikkimax @thewilsonator