Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document unittest attributes. #685

Merged
merged 1 commit into from
Oct 31, 2014
Merged

Document unittest attributes. #685

merged 1 commit into from
Oct 31, 2014

Conversation

quickfur
Copy link
Member

No description provided.

@DmitryOlshansky
Copy link
Member

Aye, let's document this, especially since it must be used for years now.

DmitryOlshansky added a commit that referenced this pull request Oct 31, 2014
@DmitryOlshansky
Merge pull request #685 from quickfur/unittest_attrs
4770ba1 
Document unittest attributes.
@DmitryOlshansky DmitryOlshansky merged commit 4770ba1 into dlang:master Oct 31, 2014
@quickfur quickfur deleted the unittest_attrs branch October 31, 2014 20:28
@9rnsr
Copy link
Contributor

9rnsr commented Nov 1, 2014

This is redundant grammar change. AttributeSpecifier had already handled the prefix attributes on unittest block.

AttributeSpecifier:
    Attribute DeclarationBlock

DeclarationBlock:
    DeclDef

DeclDef:
    UnitTest

I'll open a new PR to revert it.

@9rnsr 9rnsr mentioned this pull request Nov 1, 2014
Merged
@quickfur quickfur mentioned this pull request Nov 1, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quickfur @DmitryOlshansky @9rnsr