Win32 curl download link #92

Merged
merged 4 commits into from Mar 3, 2012

Projects

None yet

5 participants

@eco
Member
eco commented Feb 29, 2012

@WalterBright This pull request relies on curl-7.24.0-dmd-win32.zip being uploaded to ftp://ftp.digitalmars.com/ before it should be merged.

@klickverbot
Member

Is there a good reason to use FTP for downloads these days? HTTP should generally cause less problems with proxies, etc.

@eco
Owner
eco commented on 1f107e0 Feb 29, 2012

No, I don't think there is any advantage to ftp protocol, @klickverbot . It's probably a disadvantage these days, actually. I did notice after I made this change that the download page was already using http for most of the ftp.dignitalmars.com links so this can be switched back.

@WalterBright
Member

It's downloading from github now.

On 2/29/2012 10:36 AM, David Nadlinger wrote:

Is there a good reason to use FTP for downloads these days? HTTP should generally cause less problems with proxies, etc.


Reply to this email directly or view it on GitHub:
#92 (comment)

@eco
Member
eco commented Feb 29, 2012

@WalterBright If you want to upload curl-7.24.0-dmd-win32.zip to GitHub instead of Digital Mars ftp I'd happily change all of the links to point at Github. I can already change the dmd.zip in the installer to point to the Github download as it is done here on the download page.

@braddr
Member
braddr commented Feb 29, 2012

See also: my comment on the commit that adds curl to the windows build. I put the curl.lib file from this zip in place and it still fails to pass the windows phobos tests. I don't have the time to dig into what's going wrong.

@WalterBright
Member

It's on github now.

@WalterBright
Member

Though Brad says it doesn't pass the Phobos tests.

@andralex
Member
andralex commented Mar 2, 2012

@WalterBright: good to go?

@eco
Member
eco commented Mar 2, 2012

This link is fine to merge, I'd say. Phobos is still pending a solution though (and the installer pull, while it would work fine, is useless without the phobos change).

@andralex andralex merged commit 4051330 into dlang:master Mar 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment