Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve notices #949

Merged
merged 1 commit into from
Apr 1, 2015
Merged

improve notices #949

merged 1 commit into from
Apr 1, 2015

Conversation

MartinNowak
Copy link
Member

  • square blocks with less shadow
  • turn whole block into clickable link
  • use dark background + accent color

@MartinNowak
improve notices
c606d0f 
- square blocks with less shadow
- turn whole block into clickable link
- use dark background + accent color
@MartinNowak MartinNowak mentioned this pull request Mar 31, 2015
Merged
@MartinNowak
Copy link
Member Author

notice

@CyberShadow
Copy link
Member

That looks very jarring on my screen at least.

@MartinNowak
Copy link
Member Author

https://dlang.dawg.eu/

@MartinNowak
Copy link
Member Author

That looks very jarring on my screen at least.

It just looks about right on mine and it's also supposed to be noticed.

@MartinNowak
Copy link
Member Author

Also the first time, that the website has a clear center of focus.

@MartinNowak
Copy link
Member Author

Two alternatives.
white
notice_white
Red A700 (#D50000)
notice_red_a700

@CyberShadow
Copy link
Member

White is much nicer. Can't say whether it's an improvement over the current design; still looks kinda like a hole in the page.

Also, I just remembered that red-on-black is almost unreadable for people with protanopia, so we should avoid that.

@CyberShadow
Copy link
Member

#950

@MartinNowak MartinNowak merged commit c606d0f into dlang:master Apr 1, 2015
@MartinNowak MartinNowak deleted the notice branch April 1, 2015 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinNowak @CyberShadow