Merge pull request #378 from dawgfoto/master

fix segfault for underfitted foreach tuple expansion
dlang · Sep 13, 2011 · 569077b · 569077b
2 parents 7569c39 + d54c1fb
commit 569077b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/statement.c b/src/statement.c
@@ -1842,7 +1842,7 @@ Statement *ForeachStatement::semantic(Scope *sc)
                     if (pos == -1)
                         break;
                 }
-                if (exps->dim > dim)
+                if (exps->dim != dim)
                     goto Lrangeerr;
 
                 for (size_t i = 0; i < dim; i++)

diff --git a/test/fail_compilation/fail352.d b/test/fail_compilation/fail352.d
@@ -0,0 +1,11 @@
+
+struct Range {
+    bool empty;
+    int front() { return 0; }
+    void popFront() { empty = true; }
+}
+
+void main() {
+    // no index for range foreach
+    foreach(i, v; Range()) {}
+}