Merge pull request #7588 from WalterBright/fix16621

fix Issue 16621 - [REG2.060] DMD hang in semantic3 on alias this merged-on-behalf-of: Sebastian Wilzbach <sebi.wilzbach@gmail.com>
dlang · Jan 4, 2018 · 72f76d0 · 72f76d0
2 parents c6761a7 + d2e2670
commit 72f76d0
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/src/dmd/mtype.d b/src/dmd/mtype.d
@@ -6,6 +6,8 @@
  * Authors:     $(LINK2 http://www.digitalmars.com, Walter Bright)
  * License:     $(LINK2 http://www.boost.org/LICENSE_1_0.txt, Boost License 1.0)
  * Source:      $(LINK2 https://github.com/dlang/dmd/blob/master/src/dmd/mtype.d, _mtype.d)
+ * Documentation:  https://dlang.org/phobos/dmd_mtype.html
+ * Coverage:    https://codecov.io/gh/dlang/dmd/src/master/src/dmd/mtype.d
  */
 
 module dmd.mtype;
@@ -6057,9 +6059,12 @@ extern (C++) final class TypeFunction : TypeNext
                      */
                     while (1)
                     {
-                        Type tat = ta.toBasetype().aliasthisOf();
+                        Type tab = ta.toBasetype();
+                        Type tat = tab.aliasthisOf();
                         if (!tat || !tat.implicitConvTo(tprm))
                             break;
+                        if (tat == tab)
+                            break;
                         ta = tat;
                     }
 

diff --git a/test/compilable/test16621.d b/test/compilable/test16621.d
@@ -0,0 +1,23 @@
+// https://issues.dlang.org/show_bug.cgi?id=16621
+
+template xxx()
+{
+    Vector2f xxx()
+    {
+	 return this;
+    }
+}
+
+struct Vector2f
+{
+    mixin xxx!();
+    alias xxx this;
+}
+
+void foo(ref Vector2f pos);
+
+void test()
+{
+    Vector2f v;
+    foo(v);
+}