Merge pull request #9066 from WalterBright/fix19389

fix Issue 19389 - Multiple assignment does not work for struct members merged-on-behalf-of: Razvan Nitu <RazvanN7@users.noreply.github.com>
dlang · Dec 12, 2018 · 9f849a4 · 9f849a4
2 parents 20d13c6 + 62500a6
commit 9f849a4
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/src/dmd/expressionsem.d b/src/dmd/expressionsem.d
@@ -7843,6 +7843,8 @@ private extern (C++) final class ExpressionSemanticVisitor : Visitor
                     DotVarExp dve = (ce && ce.e1.op == TOK.dotVariable)
                         ? cast(DotVarExp)ce.e1 : null;
                     if (sd.ctor && ce && dve && dve.var.isCtorDeclaration() &&
+                        // https://issues.dlang.org/show_bug.cgi?id=19389
+                        dve.e1.op != TOK.dotVariable &&
                         e2y.type.implicitConvTo(t1))
                     {
                         /* Look for form of constructor call which is:

diff --git a/test/runnable/sctor.d b/test/runnable/sctor.d
@@ -446,6 +446,33 @@ void test15869()
     assert(xx.a.value == 1);
 }
 
+/***************************************************/
+// https://issues.dlang.org/show_bug.cgi?id=19389
+
+struct Foo19389 {
+    int x;
+
+    this(int dummy) { x = dummy; }
+}
+
+struct Bar19389 {
+    Foo19389 a;
+    Foo19389 b;
+
+    this(int dummy) {
+        a = (b = Foo19389(dummy));
+    }
+}
+
+
+void test19389()
+{
+    Bar19389 bar = Bar19389(7);
+    assert(bar.a.x == 7);
+    assert(bar.b.x == 7); // fails
+}
+
+
 /***************************************************/
 
 int main()
@@ -458,6 +485,7 @@ int main()
     test14944();
     test15665();
     test15869();
+    test19389();
 
     printf("Success\n");
     return 0;