Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dlang/dmd
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: acbe13ee54e0
Choose a base ref
...
head repository: dlang/dmd
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5ae249a6737e
Choose a head ref
  • 5 commits
  • 6 files changed
  • 2 contributors

Commits on May 13, 2015

  1. [Refactoring] Rename field sds to scopesym 

    Because it was confusing with parameter `sds` in some member functions.
    @9rnsr
    9rnsr committed May 13, 2015
    Configuration menu
    Copy the full SHA
    779349b View commit details
    Browse the repository at this point in the history

  2. Move issue 7815 case to fail_compilation, because it was invalid 

    It was wrongly accepted by the bug in `StaticIfCondition::include()`.

Bug explanation copied from fail_compilation/fail7815.d:
----
When the Move struct member is analyzed:
1. mixin Helpers!() is instantiated.
2. In Helpers!(), static if and its condition is(Flags!Move)) evaluated.
3. In Flags!Move, string mixin evaluates and CTFE lambda.
4. __traits(derivedMembers, Move) tries to see the member of Move.
   4a. mixin Helpers!() member is analyzed.
   4b. `static if (is(Flags!Move))` in Helpers!() is evaluated
   4c. The Flags!Move instantiation is already in progress, so it cannot be resolved.
   4d. `static if` fails because Flags!Move cannot be determined as a type.
5. __traits(derivedMembers, Move) returns a 1-length tuple("a").
6. The lambda in Flags!Move returns a string "struct Flags {...}", then
   Flags!Move is instantiated to a new struct Flags.
7. Finally Move struct does not have flags member, then the `enum a7815`
   definition will fail in its initializer.
    @9rnsr
    9rnsr committed May 13, 2015
    Configuration menu
    Copy the full SHA
    d0c854a View commit details
    Browse the repository at this point in the history

  3. fix Issue 14549 - isVirtualMethod does not work well with Github DMD

    @9rnsr
    9rnsr committed May 13, 2015
    Configuration menu
    Copy the full SHA
    a0791d5 View commit details
    Browse the repository at this point in the history

  4. Fix regression case, defer string mixin resolution

    @9rnsr
    9rnsr committed May 13, 2015
    Configuration menu
    Copy the full SHA
    0bbde0b View commit details
    Browse the repository at this point in the history

  5. Merge pull request #4635 from 9rnsr/fix14549 

    Issue 14549 - isVirtualMethod does not work well with Github DMD
    @WalterBright
    WalterBright committed May 13, 2015
    Configuration menu
    Copy the full SHA
    5ae249a View commit details
    Browse the repository at this point in the history
Loading