top level const types in function parameters should not mangle as const

[dlangBugzillaToGithub]

Walter Bright (@WalterBright) reported this on 2019-04-02T20:32:57Z

Transferred from https://issues.dlang.org/show_bug.cgi?id=19785

CC List

• ag0aep6g

Description

void foo(const int i) { }
  void bar(int i) { }

Mangles as:

  _D4test3fooFxiZv
  _D4test3barFiZv

The 'x' is not necessary in the mangling for foo(), as the const would only apply to the internal behavior of foo(), and is not relevant to the caller.

[dlangBugzillaToGithub]

ag0aep6g commented on 2019-04-02T21:16:09Z

I suppose these should also mangle the same then:

    void foo(const int* p) {}
    void bar(const(int)* p) {}

And these, too:

    void foo(const int[] p) {}
    void bar(const(int)[] p) {}

I.e., remove the top level of const for mangling.

[dlangBugzillaToGithub]

dlang-bot commented on 2019-04-04T08:27:35Z

@WalterBright created dlang/dmd pull request #9556 "fix Issue 19785 - top level const types in function parameters should…" fixing this issue:

- fix Issue 19785 - top level const types in function parameters should not mangle as const

https://github.com/dlang/dmd/pull/9556

[dlangBugzillaToGithub]

bugzilla (@WalterBright) commented on 2019-04-04T08:28:27Z

(In reply to ag0aep6g from comment #1)
> I suppose these should also mangle the same then:

Yes.