Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dmd-cxx] fix Issue 19911 - ICE: Segmentation fault with struct object and variadic function #10003

Merged
merged 1 commit into from
Jun 9, 2019
Merged

[dmd-cxx] fix Issue 19911 - ICE: Segmentation fault with struct object and variadic function #10003

merged 1 commit into from
Jun 9, 2019

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Jun 9, 2019

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 19911 critical ICE: Segmentation fault with struct object and variadic function

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "dmd-cxx + dmd#10003"

@ibuclaw ibuclaw merged commit 0f6cbbc into dlang:dmd-cxx Jun 9, 2019
@ibuclaw ibuclaw deleted the dmd-cxx-19911 branch June 9, 2019 14:06
kraj pushed a commit to kraj/gcc that referenced this pull request Jun 16, 2019
PR d/90651
985afca 
d/dmd: Merge upstream dmd 0f6cbbcad

Fixes segmentation fault in FuncDeclaration::semantic3.

Reviewed-on: dlang/dmd#10003

gcc/d/ChangeLog:

2019-06-16  Iain Buclaw  <ibuclaw@gdcproject.org>

	* typeinfo.cc (object_module): New variable.
	(make_frontend_typeinfo): Update signature.  Set temporary on
	generated TypeInfo classes.
	(create_tinfo_types): Set object_module.  Move generation of front-end
	typeinfo into ...
	(create_frontend_tinfo_types): ... New function.
	(layout_typeinfo): Call create_frontend_tinfo_types.
	(layout_classinfo): Likewise.
	(layout_cpp_typeinfo): Likewise.
	(create_typeinfo): Likewise.

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@272345 138bc75d-0d04-0410-961f-82ee72b054a4
asiekierka pushed a commit to WonderfulToolchain/gcc-ia16 that referenced this pull request May 16, 2022
@ibuclaw
re PR d/90651 (ICE in FuncDeclaration::semantic3, at d/dmd/func.c:1524)
88ad43b 
	PR d/90651
d/dmd: Merge upstream dmd 0f6cbbcad

Fixes segmentation fault in FuncDeclaration::semantic3.

Reviewed-on: dlang/dmd#10003

gcc/d/ChangeLog:

2019-06-16  Iain Buclaw  <ibuclaw@gdcproject.org>

	* typeinfo.cc (object_module): New variable.
	(make_frontend_typeinfo): Update signature.  Set temporary on
	generated TypeInfo classes.
	(create_tinfo_types): Set object_module.  Move generation of front-end
	typeinfo into ...
	(create_frontend_tinfo_types): ... New function.
	(layout_typeinfo): Call create_frontend_tinfo_types.
	(layout_classinfo): Likewise.
	(layout_cpp_typeinfo): Likewise.
	(create_typeinfo): Likewise.

From-SVN: r272345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob-carlborg jacob-carlborg jacob-carlborg approved these changes

Assignees
No one assigned
Labels
Legacy:C++ Port Severity:Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibuclaw @dlang-bot @jacob-carlborg