Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dmd-cxx] fix Issue 19890 - ICE: Segmentation fault with negative array size #10007

Merged
merged 1 commit into from
Jun 9, 2019

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Jun 9, 2019

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jun 9, 2019

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
19890 critical ICE: Segmentation fault with negative array size

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "dmd-cxx + dmd#10007"

@ibuclaw ibuclaw changed the title fix Issue 19890 - ICE: Segmentation fault with negative array size [dmd-cxx] fix Issue 19890 - ICE: Segmentation fault with negative array size Jun 9, 2019
// PERMUTE_ARGS:
/*
---
fail_compilation/fail19890a.d(8): Error: `void[/^[0-9]+(LU)?$/]` size 1 * /^[0-9]+$/ exceeds 0x7fffffff size limit for static array
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if the error message could mention that a negative value has been used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'll be a feature request for master.

@ibuclaw ibuclaw merged commit c6887d9 into dlang:dmd-cxx Jun 9, 2019
@ibuclaw ibuclaw deleted the dmd-cxx-19890 branch June 9, 2019 14:09
kraj pushed a commit to kraj/gcc that referenced this pull request Jun 16, 2019
d/dmd: Merge upstream dmd c6887d9bb

Fixes segmentation fault in castTo::CastTo::visit.

Reviewed-on: dlang/dmd#10007

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@272348 138bc75d-0d04-0410-961f-82ee72b054a4
asiekierka pushed a commit to WonderfulToolchain/gcc-ia16 that referenced this pull request May 16, 2022
	PR d/90560
d/dmd: Merge upstream dmd c6887d9bb

Fixes segmentation fault in castTo::CastTo::visit.

Reviewed-on: dlang/dmd#10007

From-SVN: r272348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants