-
-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue 1252 - Inline assembler could support BasicType properties #10069
Conversation
|
Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#10069" |
|
I think this PR should have an accompanying spec update. |
|
Yes, I mentioned this in the opening message. You can add the matching Label please. |
|
ping, the spec is merged but not the implementation. |
|
ping again |
Asm operand support for BasicType properties. This worked already when the BasicType was a template parameter but not when using the keyword literally. This is not a bug fix so this (small) addition, if accepted, would be accompanied by a dlang.org PR.