Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 1252 - Inline assembler could support BasicType properties #10069

Merged
merged 1 commit into from Jul 5, 2019
Merged

fix issue 1252 - Inline assembler could support BasicType properties #10069

merged 1 commit into from Jul 5, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 20, 2019

Asm operand support for BasicType properties. This worked already when the BasicType was a template parameter but not when using the keyword literally. This is not a bug fix so this (small) addition, if accepted, would be accompanied by a dlang.org PR.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jun 20, 2019

Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
1252 enhancement Inline assembler could support BasicType properties

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10069"

src/dmd/iasmdmd.d Outdated Show resolved Hide resolved
src/dmd/iasmdmd.d Outdated Show resolved Hide resolved
src/dmd/iasmdmd.d Outdated Show resolved Hide resolved
src/dmd/iasmdmd.d Outdated Show resolved Hide resolved
@JinShil
Copy link
Contributor

JinShil commented Jun 21, 2019

I think this PR should have an accompanying spec update.

@ghost
Copy link
Author

ghost commented Jun 21, 2019

Yes, I mentioned this in the opening message. You can add the matching Label please.

@ghost
Copy link
Author

ghost commented Jul 4, 2019

ping, the spec is merged but not the implementation.

@ghost
Copy link
Author

ghost commented Jul 4, 2019

ping again

@dlang-bot dlang-bot merged commit edfba6d into dlang:master Jul 5, 2019
@ghost ghost deleted the issue-1252 branch July 5, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants