[Repost] Issue 8220 - invalid function call not detected during semantic analysis #1007

Merged
merged 1 commit into from Mar 7, 2013

Conversation

Projects
None yet
4 participants
@9rnsr
Member

9rnsr commented Jun 15, 2012

http://d.puremagic.com/issues/show_bug.cgi?id=8220

This pull is identical to #1000. @WalterBright reverted #1000, because of the breaking of test case that he has, but I think it is genuinely invalid code (my comment).

@donc

This comment has been minimized.

Show comment
Hide comment
@donc

donc Nov 22, 2012

Collaborator

I agree with you. I have written code like Walter's example in the past, and I later rewrote it because I decided it was wrong. int + int isn't valid, and typeof(int + int) shouldn't be, either. It's easy enough to add .init to every type to turn those into valid expressions. It's not like it's a silent breakage.

But only Walter can merge this.

Collaborator

donc commented Nov 22, 2012

I agree with you. I have written code like Walter's example in the past, and I later rewrote it because I decided it was wrong. int + int isn't valid, and typeof(int + int) shouldn't be, either. It's easy enough to add .init to every type to turn those into valid expressions. It's not like it's a silent breakage.

But only Walter can merge this.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Dec 2, 2012

LGTM. @WalterBright please merge this before any more people start assuming that Type+Type is meaningful (6 months and counting!). AFAIK the specs never mention this as valid code, but you've said you told some people it does work. Couldn't you tell them about .init?

ghost commented Dec 2, 2012

LGTM. @WalterBright please merge this before any more people start assuming that Type+Type is meaningful (6 months and counting!). AFAIK the specs never mention this as valid code, but you've said you told some people it does work. Couldn't you tell them about .init?

WalterBright added a commit that referenced this pull request Mar 7, 2013

Merge pull request #1007 from 9rnsr/fix8220
[Repost] Issue 8220 - invalid function call not detected during semantic analysis

@WalterBright WalterBright merged commit 3644943 into dlang:master Mar 7, 2013

1 check was pending

default Pass: 8, Pending: 2
Details
@quickfur

This comment has been minimized.

Show comment
Hide comment
@quickfur

quickfur Mar 7, 2013

Member

This pull introduced a regression:

http://d.puremagic.com/issues/show_bug.cgi?id=9659

Member

quickfur commented Mar 7, 2013

This pull introduced a regression:

http://d.puremagic.com/issues/show_bug.cgi?id=9659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment