Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 20000 - Casting to interfaces disallowed in @safe code #10080

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

n8sh
Copy link
Member

@n8sh n8sh commented Jun 23, 2019

Takes into account @Basile-z's warning about extern(C++).

@dlang-bot
Copy link
Contributor

dlang-bot commented Jun 23, 2019

Thanks for your pull request, @n8sh!

Bugzilla references

Auto-close Bugzilla Severity Description
20000 normal Casting to interfaces disallowed in @safe code

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10080"

@n8sh n8sh force-pushed the issue-20000 branch 2 times, most recently from 6e9fedc to e51ffcb Compare June 23, 2019 22:28
@ghost
Copy link

ghost commented Jun 23, 2019

You should insert "fix " to the git commit message because the issue is only referenced and not marked for auto-closing.

@ghost
Copy link

ghost commented Jun 23, 2019

Cpp class to cpp class is not safe either. There was a related issue in DMD itself recently.

@n8sh n8sh changed the title Issue 20000 - Casting to interfaces arbitrarily disallowed in @safe code Issue 20000 - Casting to interfaces disallowed in @safe code Jun 23, 2019
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a little note about all of that should be added in the @safe specs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants