Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 19295 - ICE when taking address of member function passed as template parameter #10123

Merged
merged 1 commit into from Jul 3, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 2, 2019

A check missed after getRightThis() for DelegateExp. As a consequence the CTFE engine was faced to unexpected stuff when evaluating the pragma.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19295 normal ICE when taking address of member function passed as template parameter

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10123"

@ghost
Copy link
Author

ghost commented Jul 2, 2019

@dlang-bot is on a free day maybe ? It doesn't work for dlang-community either.

@thewilsonator thewilsonator merged commit 38a84b5 into dlang:stable Jul 3, 2019
@ghost ghost deleted the issue-19295 branch July 3, 2019 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants