Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 19708 - Can't use __traits(getAttributes, ...)[...] as a type #10143

Closed
wants to merge 1 commit into from
Closed

fix issue 19708 - Can't use __traits(getAttributes, ...)[...] as a type #10143

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 6, 2019

The first part of the fix is simply to extract Types from TypeExprs when a TypeTrait returning a TypeTuple contained some .

The second part is more delicate. A flag used by the TypeTraits was not set correctly because the TypeTrait was not directly aliased but wrapper in a TypeNext.

And finally there's a problem with git here. Walter appears as author for some reasons I don' understand.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19708 normal Can't use __traits(getAttributes, ...)[...] as a type

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10143"

@ghost ghost closed this Jul 6, 2019
@ghost ghost deleted the issue-19708 branch July 6, 2019 11:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants