Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 20044 - Compiler crash when using an opaque struct as template parameter #10173

Merged
merged 1 commit into from Jul 15, 2019
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jul 14, 2019

Just an unchecked access

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20044 critical Compiler crash when using an opaque struct as template parameter

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10173"

@ghost ghost changed the title fix issue 20044 - Compiler crash when using an opaque struct as templ… fix issue 20044 - Compiler crash when using an opaque struct as template parameter Jul 14, 2019
@dlang-bot dlang-bot merged commit 0d4098b into dlang:stable Jul 15, 2019
@ghost ghost deleted the issue-20044 branch July 15, 2019 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants