Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 20057 - compiler hang on conflicting local and imported template #10194

Merged
merged 1 commit into from Jul 18, 2019
Merged

fix issue 20057 - compiler hang on conflicting local and imported template #10194

merged 1 commit into from Jul 18, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 18, 2019

The regression is on master only and was caused by #10078

@dlang-bot
Copy link
Contributor

dlang-bot commented Jul 18, 2019

Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20057 regression compiler hang on conflicting local and imported template

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10194"

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please target stable.

@ghost
Copy link
Author

ghost commented Jul 18, 2019

No, the regression is on master only (was caused by #10078)

@dlang-bot dlang-bot merged commit 8fb7821 into dlang:master Jul 18, 2019
@ghost ghost deleted the issue-20057 branch July 18, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants