fix issue 11856 - segfault with circular template constraints #10205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + dmd#10205" |
thewilsonator
approved these changes
Jul 21, 2019
ghost
deleted the
PetarKirov
reviewed
Jul 21, 2019
| @@ -642,6 +642,7 @@ extern (C++) abstract class Expression : ASTNode | |||
| ubyte parens; // if this is a parenthesized expression | |||
| Type type; // !=null means that semantic() has been run | |||
| Loc loc; // file location | |||
| ubyte inuse; // detect expressionSemantic() loops | |||
There was a problem hiding this comment.
Please open a PR to update the .h file.
ghost
mentioned this pull request
dlang-bot
added a commit
that referenced
this pull request
Jul 21, 2019
add missing c++ headers change from #10205 merged-on-behalf-of: Petar Kirov <ZombineDev@users.noreply.github.com>
wilzbach
pushed a commit
to wilzbach/dmd
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is fixed by adding an
inuseflag, like existing for declarations and templates. Memory usage won't be affected becauseExpressionsize was already not divisible by the platform alignment.