Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 20067 - [REG2.086] foreach no longer works on range with alias front #10206

Merged
merged 1 commit into from Jul 23, 2019
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jul 21, 2019

Trivial, just a call to toAlias() missing

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20067 regression [REG2.086] foreach no longer works on range with alias front

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10206"

test/compilable/b20067.d Outdated Show resolved Hide resolved
@kinke
Copy link
Contributor

kinke commented Jul 21, 2019

I guess the other cases (sfront.isFuncDeclaration() etc.) should be alias-resolved too.

@ghost
Copy link
Author

ghost commented Jul 22, 2019

@kinke, the test case shows that this is not required.

@ghost
Copy link
Author

ghost commented Jul 23, 2019

Good to merge then.

@ghost
Copy link
Author

ghost commented Jul 23, 2019

ping @thewilsonator

1 similar comment
@ghost
Copy link
Author

ghost commented Jul 23, 2019

ping @thewilsonator

@ghost ghost closed this Jul 23, 2019
@ghost ghost reopened this Jul 23, 2019
@ghost
Copy link
Author

ghost commented Jul 23, 2019

one thing after contacting andrei that is clear, is that a bug fixer like me will get nothing, not a single fucking euro, so at least I expect a bit of respect when I fix a bug. When it's good, you merge.

@dlang-bot dlang-bot merged commit e22c733 into dlang:stable Jul 23, 2019
@thewilsonator
Copy link
Contributor

Sorry your ping came a 1am and 2am my time.

JohanEngelen added a commit to weka/ldc that referenced this pull request Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants