-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue 20067 - [REG2.086] foreach no longer works on range with alias front #10206
Conversation
|
Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + dmd#10206" |
|
I guess the other cases ( |
|
@kinke, the test case shows that this is not required. |
|
Good to merge then. |
|
ping @thewilsonator |
1 similar comment
|
ping @thewilsonator |
|
one thing after contacting andrei that is clear, is that a bug fixer like me will get nothing, not a single fucking euro, so at least I expect a bit of respect when I fix a bug. When it's good, you merge. |
|
Sorry your ping came a 1am and 2am my time. |
Trivial, just a call to
toAlias()missing