Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20136 - opEquals not recognized for AA key #10320

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Aug 19, 2019

[1] Adds a v.needThis check that verifies that the variable has the STC.field storage set, however this field is set only after semantic has been ran on a var declaration.

This patch makes it so that check is valid only if semantic has been ran on that specific variable.

[1] #9884

@dlang-bot
Copy link
Contributor

dlang-bot commented Aug 19, 2019

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20136 regression opEquals not recognized for AA key

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10320"

@RazvanN7 RazvanN7 added the Severity:Regression PRs that fix regressions label Aug 19, 2019
@RazvanN7 RazvanN7 changed the base branch from master to stable August 19, 2019 14:46
@thewilsonator thewilsonator merged commit 0b3ce79 into dlang:stable Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants