Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 20021 - static if doesn't evaluate opCast(bool) #10324

Merged
merged 2 commits into from
Aug 20, 2019

Conversation

aG0aep6G
Copy link
Contributor

This is a reboot of #10237 which apparently was ready to go, but @dkorpel encountered problems when rebasing to stable.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @aG0aep6G! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20021 regression static if doesn't evaluate opCast(T : bool)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10324"

@dkorpel
Copy link
Contributor

dkorpel commented Aug 20, 2019

Funny, I was just opening my reboot for this when I saw this popping up.
The tests are failing because the extra line fail_compilation/ice11553.d(22): changes the line number to 23.

@aG0aep6G
Copy link
Contributor Author

Funny, I was just opening my reboot for this when I saw this popping up.

Great minds think alike, I guess :)
If you want to pursue this yourself, just let me know and I'll close this.

@dlang-bot dlang-bot merged commit 421e9ce into dlang:stable Aug 20, 2019
@aG0aep6G aG0aep6G deleted the static-if-bool branch August 20, 2019 21:50
tramker added a commit to tramker/dmd that referenced this pull request Sep 27, 2019
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

Conflicts:
	src/dmd/staticcond.d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants