Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 4372, 982 - CodeView: type of enumerator values reduced to … #10328

Merged
merged 1 commit into from Aug 23, 2019

Conversation

rainers
Copy link
Member

@rainers rainers commented Aug 21, 2019

…base type in debug info

write a forward reference to the enum definition, it is emitted elsewhere

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @rainers!

Bugzilla references

Auto-close Bugzilla Severity Description
982 normal Codeview: symbols of enum type are declared integer
4372 normal type of enumerator values reduced to base type in debug info

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10328"

@rainers
Copy link
Member Author

rainers commented Aug 21, 2019

This doesn't change the debug type if the enum has a complex base type (e.g. string), but that's probably better as it will be unexpected for most debuggers. mago also needed a tiny patch: rainers/mago@dd6b602

@thewilsonator
Copy link
Contributor

Exception - file 'dmd\backend/code_stub.h': dmd\backend/code_stub.h: The system cannot find the file specified.
Exception - file 'dmd\backend/platform_stub.c': dmd\backend/platform_stub.c: The system cannot find the file specified.
Error - file 'dmd\backend\dcgcv.d' contains trailing whitespace at line 1748
Exception - file 'dmd\backend\backend.txt': dmd\backend\backend.txt: The system cannot find the file specified.

@thewilsonator
Copy link
Contributor

Exception - file 'dmd\backend/code_stub.h': dmd\backend/code_stub.h: The system cannot find the file specified.
Exception - file 'dmd\backend/platform_stub.c': dmd\backend/platform_stub.c: The system cannot find the file specified.
Error - file 'dmd\backend\dcgcv.d' contains trailing whitespace at line 1748
Exception - file 'dmd\backend\backend.txt': dmd\backend\backend.txt: The system cannot find the file specified.

3 similar comments
@thewilsonator
Copy link
Contributor

Exception - file 'dmd\backend/code_stub.h': dmd\backend/code_stub.h: The system cannot find the file specified.
Exception - file 'dmd\backend/platform_stub.c': dmd\backend/platform_stub.c: The system cannot find the file specified.
Error - file 'dmd\backend\dcgcv.d' contains trailing whitespace at line 1748
Exception - file 'dmd\backend\backend.txt': dmd\backend\backend.txt: The system cannot find the file specified.

@thewilsonator
Copy link
Contributor

Exception - file 'dmd\backend/code_stub.h': dmd\backend/code_stub.h: The system cannot find the file specified.
Exception - file 'dmd\backend/platform_stub.c': dmd\backend/platform_stub.c: The system cannot find the file specified.
Error - file 'dmd\backend\dcgcv.d' contains trailing whitespace at line 1748
Exception - file 'dmd\backend\backend.txt': dmd\backend\backend.txt: The system cannot find the file specified.

@thewilsonator
Copy link
Contributor

Exception - file 'dmd\backend/code_stub.h': dmd\backend/code_stub.h: The system cannot find the file specified.
Exception - file 'dmd\backend/platform_stub.c': dmd\backend/platform_stub.c: The system cannot find the file specified.
Error - file 'dmd\backend\dcgcv.d' contains trailing whitespace at line 1748
Exception - file 'dmd\backend\backend.txt': dmd\backend\backend.txt: The system cannot find the file specified.

…base type in debug info

write a forward reference to the enum definition, it is emitted elsewhere
@rainers
Copy link
Member Author

rainers commented Aug 22, 2019

Error - file 'dmd\backend\dcgcv.d' contains trailing whitespace at line 1748

Fixed and test case added.

@Geod24 Geod24 merged commit b1a6d3b into dlang:master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants