Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 20212 - invalid debug info with enum type in library #10407

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

rainers
Copy link
Member

@rainers rainers commented Sep 13, 2019

reusing an old type index does not work because it might be in a different object file. Let cv_debtyp() sort out duplicates instead.

Regression is on master only (no enum type debug info emitted before). A test as in the report seems excessive, there is a test in runnable/testpdb.d that emission still works.

reusing an old type index does not work because it might be in a different object file. Let cv_debtyp() sort out duplicates instead.
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @rainers!

Bugzilla references

Auto-close Bugzilla Severity Description
20212 regression invalid debug info with enum type in library

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10407"

@dlang-bot dlang-bot merged commit bc93e5e into dlang:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants