Revert "Remove backend globals from header modules"

[WalterBright]

Reverts #10455, reason why is given there.

[dlang-bot]

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10460"

[marler8997]

I'm copying my comment from #10455:

Walter I opened #10255 3 months ago. In that original PR I had put these globals into a separate file so that the other modules would'nt have to import the entire cg87.d file. You left this comment:

Adding a new file seems like overkill for 3 variables.

So I left the variables in cg87.d made everything private except those variables and then imported cg87.d and waited for your feedback for 3 months. You were also pinged by @ZombineDev a month later and you still left no feedback.

In the future, I'm sure everyone would be very grateful if you did the following

1. When you object to a change, and a developer refactors their code according to that objection, please follow up and respond.

2. Instead of only saying why you don't like a change, consider providing guidance on how they could change their solution to a form that you will like.

That being said, I don't know how this change could affect the compilation time of the backend. The backend is compiled in a single invocation so the cg87.d file will only be parsed/analyzed once anyway. Do you have data that shows this increases compilation time? As @andralex says, "Always Measure".

[WalterBright]

I also use the backend for the DMC++ compiler. Making changes just for DMD often break that, causing extra work for me, including this change. The backend uses the header/implementation file dichotomy, mixing that up here and there with the frontend style doesn't help much of any.

I'm sorry I had not noticed these changes earlier. There's only so much of me to go around. On the other hand, this is just a handful of lines, so it's not like a major effort was wasted.

I've repeatedly objected to making changes that are essentially shuffling files around. Finding declarations to make private, though, is a productive change.

[marler8997]

I just don't want these internal backend globals to be in a shared header with the frontend. Do you have an alternative solution?

[WalterBright]

You could make a backend.d header for the backend globals.

[marler8997]

You could make a backend.d header for the backend globals.

Perfect. Go ahead and revert my original change and I'll work on that change.