Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20280 - Compiler segfault when building two small files #10465

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

RazvanN7
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Oct 10, 2019

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20280 critical Compiler segfault when building two small files

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10465"

@RazvanN7 RazvanN7 changed the base branch from master to stable October 10, 2019 09:40
@@ -0,0 +1,8 @@
// PERMUTE_ARGS:
// REQUIRED_ARGS: -Icompilable/extra-files
// EXTRA_FILES: extra-files/example7190/controllers/HomeController.d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like this file is in this PR

@RazvanN7
Copy link
Contributor Author

I think that the buildkite failure is unrelated to this patch.

@thewilsonator
Copy link
Contributor

They seem annoyingly consistent, but they do look unrelated. Maybe try rebasing?

@wilzbach wilzbach merged commit da6fc42 into dlang:stable Nov 26, 2019
@wilzbach
Copy link
Member

I think that the buildkite failure is unrelated to this patch.

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants