Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue 15118 - Win32: default to using optlink.exe with the Digital Mars toolchain #10468

Merged
merged 1 commit into from
Oct 20, 2019
Merged

fix issue 15118 - Win32: default to using optlink.exe with the Digital Mars toolchain #10468

merged 1 commit into from
Oct 20, 2019

Conversation

rainers
Copy link
Member

@rainers rainers commented Oct 11, 2019 •
edited
Loading

There has been a previous attempt but that changed the default for the MS toolchain: #5147

optlink.exe has been shipped alongside link.exe since 2.069 2.079.

More things to do on the installer side:

  • write appropriate sc.ini
  • remove link.exe from installation

@dlang-bot
Copy link
Contributor

dlang-bot commented Oct 11, 2019 •
edited
Loading

Thanks for your pull request, @rainers!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 15118 enhancement Have dmd on Win32 look for optlink.exe instead of link.exe

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10468"

@kinke
Copy link
Contributor

kinke commented Oct 11, 2019

remove link.exe from installation

Great, this will mitigate issues for newbies on Windows, not just for DMD; LDC users with wrong PATH config have ended up invoking optlink too.

@rainers rainers mentioned this pull request Oct 20, 2019
Merged
@rainers rainers changed the base branch from master to stable October 20, 2019 13:49
@rainers
Copy link
Member Author

rainers commented Oct 20, 2019

rebased to stable, installer PR here: dlang/installer#403

@dlang-bot dlang-bot merged commit 4208996 into dlang:stable Oct 20, 2019
@PetarKirov
Copy link
Member

@rainers feel free to merge dlang/installer#403.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PetarKirov PetarKirov PetarKirov approved these changes

Assignees
No one assigned
Labels
Merge:auto-merge Severity:Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rainers @dlang-bot @kinke @PetarKirov