Issue 20376 - @disable this(ref return scope Foo rhs) enables broken binaries (out-of-bounds access)

[RazvanN7]

The conversion is handled by the copy constructor only when the return value is an lvalue and the object has a defined copy constructor.

[dlang-bot]

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	20376	regression	@disable this(ref return scope Foo rhs) enables broken binaries (out-of-bounds access)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10558"

[RazvanN7]

I think that the buildkite failure is due to a version mismatch (dmd - stable branch, phobos/druntime - master branch). Is there any way I can fix this?

[wilzbach]

Well, the problem is that Buildkite doesn't detect master to stable changes immediately and thus sets this:

BUILDKITE_PULL_REQUEST_BASE_BRANCH="master"

from: https://buildkite.com/dlang/dmd/builds/10208#703fe997-f4f1-40f8-bb8d-038b78a4628e
used in: https://github.com/dlang/ci/blob/master/buildkite/origin_target_branch.sh

tl;dr: a force-push will change fix the BUILDKITE_PULL_REQUEST_BASE_BRANCH variable.

Full discussion: buildkite/feedback#306