Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 10562 dont flatten arrays to 1D when #10600

Merged
merged 1 commit into from Nov 22, 2019

Conversation

benjones
Copy link
Contributor

RHS is an array

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @benjones! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
10562 normal Cannot initialize arrays by an element value when the elements are fixed-length arrays

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10600"

@dlang-bot dlang-bot merged commit c1d076e into dlang:master Nov 22, 2019
@MoonlightSentinel
Copy link
Contributor

MoonlightSentinel commented Dec 25, 2019

This introduced a regression https://issues.dlang.org/show_bug.cgi?id=20465.
Fix: #10698

@benjones benjones deleted the bug10562 branch May 19, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants