Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 19432 automatically interpret big int literals as #10607

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

benjones
Copy link
Contributor

unsigned longs if they don't fit in a signed long.

I made a corresponding PR for dlang.org, but I don't know the best way to PRs

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @benjones! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19432 normal Cannot initialize ulong with decimal value above signed long range

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10607"

@thewilsonator thewilsonator added Review:Needs Spec PR A PR updating the language specification needs to be submitted to dlang.org Merge:auto-merge and removed Review:Needs Spec PR A PR updating the language specification needs to be submitted to dlang.org labels Nov 22, 2019
@dlang-bot dlang-bot merged commit 2adfe97 into dlang:master Nov 27, 2019
@benjones benjones deleted the bug19432 branch May 19, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants