Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20419 - is(missing == module/package) results in unknown id… #10621

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

MoonlightSentinel
Copy link
Contributor

@MoonlightSentinel MoonlightSentinel commented Nov 26, 2019

…entifier.

is(missing == module) and is(missing == package) raised an error for missing identifiers, violating the language specification wich only requires the identifier to be syntactically valid.

…entifier

is(missing == module) and is(missing == package) raised an error for missing
identifiers, violating the language specification wich only requires the
identifier to be syntactically valid.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20419 normal is(missing == module/package) results in unknown identifier

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10621"

@dlang-bot dlang-bot merged commit 7b174a3 into dlang:master Nov 27, 2019
@Geod24
Copy link
Member

Geod24 commented Nov 27, 2019

Shouldn't this have gone to stable ?

@MoonlightSentinel
Copy link
Contributor Author

Shouldn't this have gone to stable ?

Why, isn't stable reserved for regressions?
(IMO this does not qualify as a regression fix because these traits were introduced with this flaw)

@Geod24
Copy link
Member

Geod24 commented Nov 27, 2019

It's also used for non-disruptive bugfixes where there is a clear benefit to the bugfix.
IMO this PR is a textbook example of that :)

@MoonlightSentinel
Copy link
Contributor Author

Okay, I'll try to remember that for my future PRs

@MoonlightSentinel MoonlightSentinel deleted the missing-module branch December 1, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants