Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20151 - particular directory layout causes DMD to crash #10675

Merged
merged 2 commits into from
Dec 19, 2019

Conversation

BorisCarvajal
Copy link
Member

Similar to issue 17991 but the foreach runs more than 1 time.
Moved the workaround to where it should be;

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @BorisCarvajal! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20151 major particular directory layout causes DMD to crash with an access violation

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10675"

@thewilsonator
Copy link
Contributor

Tests?

@BorisCarvajal
Copy link
Member Author

I forgot to say the code is covered by the test case that comes from issue 17991.

@Geod24
Copy link
Member

Geod24 commented Dec 17, 2019

I forgot to say the code is covered by the test case that comes from issue 17991.

No it's not, otherwise the testsuite wouldn't have been passing.

@thewilsonator
Copy link
Contributor

We have some network issues going on you'll need to force push to restart the doc tester at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants