Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 19998 - [REG2.086.0] [e2ir] Assertion failure with -profile… #10678

Closed
wants to merge 1 commit into from
Closed

fix Issue 19998 - [REG2.086.0] [e2ir] Assertion failure with -profile… #10678

wants to merge 1 commit into from

Conversation

WalterBright
Copy link
Member

…=gc and -dip1008

@WalterBright WalterBright added the Severity:Regression PRs that fix regressions label Dec 19, 2019
@dlang-bot
Copy link
Contributor

dlang-bot commented Dec 19, 2019 •
edited
Loading

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 19998 regression [REG2.086.0] [e2ir] Assertion failure with -profile=gc and -dip1008

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#10678"

@WalterBright
Copy link
Member Author

The bug isn't in stable, so this stays in master.

RazvanN7
RazvanN7 reviewed Dec 19, 2019
View reviewed changes
test/compilable/test20318.d Outdated

void test19998()
{
throw new Exception("");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get how this addition is any different from the already existing test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems I fixed a duplicate of the bug you fixed. I prefer the comment you made, and my fix was slightly more efficient, so I combined the two.

@RazvanN7
Copy link
Contributor

I'm confused about this. This issue seems identical to https://issues.dlang.org/show_bug.cgi?id=20318 which was fixed by #10517 . Am I missing something?

@MoonlightSentinel
Copy link
Contributor

The example compiles & runs fine with current master

@RazvanN7
Copy link
Contributor

@WalterBright ?

@ghost
Copy link

ghost commented Aug 3, 2020 •
edited by ghost
Loading

I suggest to add the test case but so far this PR has no value anymore as the problem is fixed.

@ghost ghost closed this Aug 3, 2020
@ghost ghost added the Review:Phantom Zone Has value/information for future work, but closed for now label Aug 3, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RazvanN7 RazvanN7 RazvanN7 left review comments

Assignees
No one assigned
Labels
Review:Phantom Zone Has value/information for future work, but closed for now Severity:Bug Fix Severity:Regression PRs that fix regressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WalterBright @dlang-bot @RazvanN7 @MoonlightSentinel