Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 10100 - Identifiers with double underscores and allMembers #10697

Merged
merged 1 commit into from
Dec 26, 2019

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Dec 25, 2019

Convert the identifier whitelist into a blacklist of all possible internal D language declarations.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
10100 regression Identifiers with double underscores and allMembers

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10697"

Convert the identifier whitelist into a blacklist of all possible
internal D language declarations.
@thewilsonator
Copy link
Contributor

Given the age of this, stable is probably not needed.

@dlang-bot dlang-bot merged commit fe7d5b9 into dlang:master Dec 26, 2019
@ibuclaw ibuclaw deleted the issue10100 branch December 26, 2019 11:16
tramker pushed a commit to tramker/dmd that referenced this pull request Jul 24, 2020
fix Issue 10100 - Identifiers with double underscores and allMembers
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

Signed-off-by: Martin Krejcirik <mk@krej.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants