Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20507 - Debug statements affect inference... #10726

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

MoonlightSentinel
Copy link
Contributor

...of templated functions attributes.

This was caused by marking the function as @system/non-@nogc/non-nothrow BEFORE checking whether the statement is inside an debug statement / block

...of templated functions attributes.

This was caused by marking the function as @system/non-@nogc/non-nothrow BEFORE
checking whether the statement is inside an debug statement / block
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20507 normal Debug statements affect inference of templated functions attributes

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10726"

@dlang-bot dlang-bot merged commit e35f9fc into dlang:master Jan 16, 2020
@MoonlightSentinel MoonlightSentinel deleted the infer-debug branch January 16, 2020 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants