Fix Issues 20530, 20537 - resolve trait isPackage/isModule and is(package/module) quirks

[BorisCarvajal]

…ork with string mixins

#10739 continuation.

I made two solutions to the issue of the last comment but hit another bug while trying the long alternative so I decided to put that version on another pull to fix that bug.

The short version here is changing something I wondered in the past why it was there, the typeToExpression call is unnecessary and it gave me different results a few times on compiler experiments when using mixin("ident . ident ...") vs plain code, it seems the way that TypeIdentifier is converted to DotIdExp makes the code behave different on some cases.

[dlang-bot]

Thanks for your pull request and interest in making D better, @BorisCarvajal! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	11847	major	sub-pkg not available as qualified name
✓	20530	normal	is(<...> == module/package) does not work with string mixins
✓	20537	normal	traits isPackage/isModule and is(package/module) fail on single level package.d import

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10745"

[Geod24]

@thewilsonator : Please don't auto-merge so quickly. There's no way you could have reviewed it in 2 minutes. I don't see the point of just merging without review. If we ever need this, we can just modify dlang-bot.
The previous solution had some issues, and was also prematurely merged before being reviewed. We might want to request a review from @MoonlightSentinel who actually did review and came up with good test cases last time.

[BorisCarvajal]

@Geod24: the previous solution was merged because the original bug report didn't have enough test cases, I didn't know about the test cases provided by @MoonlightSentinel.
Just saying.

[MoonlightSentinel]

@Geod24: the previous solution was merged because the original bug report didn't have enough test cases,

A bug report isn't required to show of all possible inputs reproducing a certain bug. You can always add more test cases, especially if you are not completely sure about your fix (based on your initial comment #10739 (comment))

I didn't know about the test cases provided by @MoonlightSentinel.

These tests were taken from compilable/test16002.d by changing all simple identifiers to string mixins. Searching for existing tests in the test suite is usually a good start to find missing test cases.

[BorisCarvajal]

By the way, this patch also resolves the issue 11847. Should I link the bug and upload the test case?
There is already a pull (#7218) open for that issue that seems to cover more about it. Maybe I should ask @MartinNowak if this patch has the chance to close that issue or a part of it at least.

[thewilsonator]

Should I link the bug and upload the test case?

Yes please.

[WalterBright]

Approved once definition of a "wrapper Package" is added.

[BorisCarvajal]

I made the requested changes.

[thewilsonator]

git clone -b v2.090.1 --depth=1 https://github.com/dlang/druntime .generated/druntime-2.090.1
Cloning into '.generated/druntime-2.090.1'...
warning: Could not find remote branch v2.090.1 to clone.
fatal: Remote branch v2.090.1 not found in upstream origin

Hmm, maybe try giving it a force push?

Documentation added

[BorisCarvajal]

git clone -b v2.090.1 --depth=1 https://github.com/dlang/druntime .generated/druntime-2.090.1
Cloning into '.generated/druntime-2.090.1'...
warning: Could not find remote branch v2.090.1 to clone.
fatal: Remote branch v2.090.1 not found in upstream origin

Sounds like a script bug, there is no v2.090.1 tag yet, just v2.090.1-beta.1.

[thewilsonator]

Hmm, maybe try rebasing? Otherwise I'll have to defer to @CyberShadow or someone else about that.

[BorisCarvajal]

@thewilsonator, now I see the VERSION file was bumped but still no tag on dmd, druntime and phobos, I assume it's a matter of time.

[thewilsonator]

Try giving it a force push, then I guess.