Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20551 - In @safe code and using delegates, it's possible to escape references to function frame #10756

Merged
merged 1 commit into from Feb 3, 2020

Conversation

RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Feb 3, 2020

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20551 normal In @safe code and using delegates, it's possible to escape references to function frame

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10756"

@@ -5,7 +5,7 @@ TEST_OUTPUT:
fail_compilation/fail809.d(11): Error: scope variable `dg_` may not be returned
---
*/
@safe int delegate() test(lazy int dg)
int delegate() test(lazy int dg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch makes it so that taking the address of a lazy parameter in @safe code is illegal, so it would have masked the original error.

@dlang-bot dlang-bot merged commit 6abf88b into dlang:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants