Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable 'body' keyword deprecation #10763

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Feb 5, 2020

The replacement for 'body' has been in the language since v2.075.0,
which was released July 2017.
This hasn't been long enough for some corporate users to adapt,
and the main benefit of DIP1003 was to allow to use 'body'
as a keyword, which is already possible nowadays.

Hence, this PR disables the deprecation, with the hope it can be
re-instated either in a few years, or when a more compatible release
management is in place.

CC @don-clugston-sociomantic
This hasn't been released yet.

The replacement for 'body' has been in the language since v2.075.0,
which was released July 2017.
This hasn't been long enough for some corporate users to adapt,
and the main benefit of DIP1003 was to allow to use 'body'
as a keyword, which is already possible nowadays.

Hence, this PR disables the deprecation, with the hope it can be
re-instated either in a few years, or when a more compatible release
management is in place.
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @Geod24!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10763"

@dlang-bot dlang-bot merged commit 70f816c into dlang:master Feb 6, 2020
@Geod24 Geod24 deleted the disable-body-deprecation branch February 6, 2020 09:30
@schveiguy
Copy link
Member

schveiguy commented Feb 7, 2020

What is the rationale behind reverting? The explanation in the commit says to see this PR, which has no explanation.

Edit: nevermind. I didn't read the quote, thinking it was from the other PR.

@Geod24
Copy link
Member Author

Geod24 commented Feb 7, 2020

Another part of the discussion is here: #10757 (comment)

Note that the operator overload deprecation was originally deprecated, then reverted, then re-instantiated (with an slight fix).

The scope qualifier deprecation was also reverted. This one hasn't been dealt with yet, also because while looking at it, I realized scope was just the tip of the iceberg: we have immutable, const, and shared classes and structs. But those don't expose consistent semantics (an example).

Geod24 added a commit to Geod24/dmd that referenced this pull request Mar 2, 2021
This was first deprecated in dlang#10693 (December 2019),
but was then reverted in dlang#10763 to extend the transition period.
Since the replacement will have been available for 22 releases
(almost 4 years), it should be safe to deprecate now.
Geod24 added a commit to Geod24/dmd that referenced this pull request Mar 2, 2021
This was first deprecated in dlang#10693 (December 2019),
but was then reverted in dlang#10763 to extend the transition period.
Since the replacement will have been available for 22 releases
(almost 4 years), it should be safe to deprecate now.
Geod24 added a commit to Geod24/dmd that referenced this pull request Mar 4, 2021
This was first deprecated in dlang#10693 (December 2019),
but was then reverted in dlang#10763 to extend the transition period.
Since the replacement will have been available for 22 releases
(almost 4 years), it should be safe to deprecate now.
thewilsonator pushed a commit that referenced this pull request Mar 4, 2021
This was first deprecated in #10693 (December 2019),
but was then reverted in #10763 to extend the transition period.
Since the replacement will have been available for 22 releases
(almost 4 years), it should be safe to deprecate now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants