fix Issue 19479 - Garbage .init in string mixins in static foreach in mixin templates #10767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#10767" |
… mixin templates The problem was that the mixin was being omitted from the codegen during the conversion from StaticForeachDeclaration to a Statement. The first issue with `toStatement` is that it is visiting all members in the StaticForeachDeclaration's `decl`, whereas the semantically compiled list of Dsymbols is instead found in `cache`. This is what caused the CompileDeclaration to be omitted. The second issue with `toStatement` is that converting an already compiled StaticForeachDeclaration into a new StaticForeachStatement results in `makeTupleForeach` being called twice for the same StaticForeach symbol. There is no need to create a new StaticForeachStatement, simply the unrolling of all members is enough.
thewilsonator
approved these changes
Feb 6, 2020
|
CC @tgehr |
|
Did I break something, or just notifying the original author? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that the mixin was being omitted from the codegen during the conversion from StaticForeachDeclaration to a Statement.
The first issue with
toStatementis that it is visiting all members in the StaticForeachDeclaration'sdecl, whereas the semantically compiled list of Dsymbols is instead found incache. This is what caused the CompileDeclaration to be omitted.The second issue with
toStatementis that converting an already compiled StaticForeachDeclaration into a new StaticForeachStatement results inmakeTupleForeachbeing called twice for the sameStaticForeach symbol. There is no need to create a new StaticForeachStatement, simply the unrolling of all members is enough.