Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 17145 - [REG2.066.0] Tuple expansion error in local enum de… #10774

Merged
merged 1 commit into from Feb 9, 2020
Merged

fix Issue 17145 - [REG2.066.0] Tuple expansion error in local enum de… #10774

merged 1 commit into from Feb 9, 2020

Conversation

WalterBright
Copy link
Member

…claration

This regression is several years old, so I don't think the fix should go into stable.

@WalterBright WalterBright added the Regression PRs that fix regressions label Feb 9, 2020
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 17145 regression [REG2.066.0] Tuple expansion error in local enum declaration

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10774"

@thewilsonator
Copy link
Contributor

This segfaults on libmir/mir-algorithm

@WalterBright
Copy link
Member Author

This segfaults

Not anymore.

@dlang-bot dlang-bot merged commit 545b0f9 into dlang:master Feb 9, 2020
tramker pushed a commit to tramker/dmd that referenced this pull request Jul 24, 2020
@dlang-bot @tramker
Merge pull request dlang#10774 from WalterBright/fix17145
b7b2b93 
fix Issue 17145 - [REG2.066.0] Tuple expansion error in local enum de…
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

Signed-off-by: Martin Krejcirik <mk@krej.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

Assignees
No one assigned
Labels
auto-merge Bug Fix Regression PRs that fix regressions
Projects
None yet
Milestone
No milestone
3 participants
@WalterBright @dlang-bot @thewilsonator