fix Issue 15812 - static struct inside extern(C++) class cannot be us… #10782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
|
|
Won't this require updating an error message in the test suite? |
thewilsonator
approved these changes
Feb 12, 2020
…ed as key to associative array
WalterBright
force-pushed
the
fix15812
branch
from
8a81a64
to
143f827
Compare
|
Hey what about that giant warning from dlang-bot about stable ? |
|
It's a trivial issue, and rather old. |
|
This seems like a workaround instead of a fix. Why should toHash require extern(D) but not opEquals()? |
tramker
pushed a commit
to tramker/dmd
that referenced
this pull request
Jul 24, 2020
fix Issue 15812 - static struct inside extern(C++) class cannot be us… merged-on-behalf-of: Walter Bright <WalterBright@users.noreply.github.com> Signed-off-by: Martin Krejcirik <mk@krej.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed as key to associative array
An incomplete error message.