Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20538 - malformed enum definition compiles #10783

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

alexandrumc
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @alexandrumc! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20538 minor malformed enum definition compiles

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10783"

@UplinkCoder
Copy link
Member

The testcase you provided does not compile.

@alexandrumc
Copy link
Contributor Author

The testcase you provided does not compile.

I tried with DMD64 D Compiler v2.090.0 and it does compile.

TEST_OUTPUT:
---
fail_compilation/fail20538.d(12): Error: assignment must be preceded by an identifier
fail_compilation/fail20538.d(12): Error: found `1` when expecting `,`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message suggests that a = is a valid enum member

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, but I'm open to suggestions.

@UplinkCoder
Copy link
Member

I tried with DMD64 D Compiler v2.090.0 and it does compile.
Ah yes ... I've tried with an older version.
Nevermind then.

@dlang-bot dlang-bot merged commit 79c29fe into dlang:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants