Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for fixed issue 19504 #10811

Merged
merged 1 commit into from Feb 21, 2020
Merged

Add test for fixed issue 19504 #10811

merged 1 commit into from Feb 21, 2020

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Feb 21, 2020

It works now, so just add a test for it.

@Geod24 Geod24 added the Trivial typos, formatting, comments label Feb 21, 2020
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @Geod24!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 19504 normal pragma(mangle) ignored for C++ destructors

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10811"

@Geod24 Geod24 mentioned this pull request Feb 21, 2020
Open
@Geod24
Copy link
Member Author

Geod24 commented Feb 21, 2020

Bypassing irrelevant but persistent Buildkite failure (will fix)

@Geod24 Geod24 merged commit c6577e3 into dlang:master Feb 21, 2020
@Geod24 Geod24 deleted the test-19504 branch February 21, 2020 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

Assignees
No one assigned
Labels
auto-merge Bug Fix Trivial typos, formatting, comments
Projects
None yet
Milestone
No milestone
3 participants
@Geod24 @dlang-bot @thewilsonator