Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 20421 - Exceptions don't work when linking through lld-link #10814

Merged
merged 4 commits into from
Feb 27, 2020

Conversation

rainers
Copy link
Member

@rainers rainers commented Feb 21, 2020

when linking through lld-link, add /SAFESEH:NO to linker command line

add build on azure that uses lld and mingw import libraries
use run.d instead of gmake to run tests
d_do_test: remove legacy command line "-map nul.map"
update to build with LDC 1.20.0

This adds to dlang/installer#433, some druntime fixes still necessary...

@dlang-bot
Copy link
Contributor

dlang-bot commented Feb 21, 2020

Thanks for your pull request, @rainers!

Bugzilla references

Auto-close Bugzilla Severity Description
20421 major Exceptions don't work when linking through lld-link

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10814"

@rainers rainers changed the title fix issue 20241 - Exceptions don't work when linking through lld-link fix issue 20421 - Exceptions don't work when linking through lld-link Feb 21, 2020
@rainers rainers force-pushed the azure_mingw branch 4 times, most recently from d877d41 to 2cc2eff Compare February 23, 2020 17:11
@MartinNowak
Copy link
Member

I'll branch today @rainers, let's change this PR to stable once the vcruntime.lib linking is fixed.

@rainers rainers force-pushed the azure_mingw branch 4 times, most recently from 5e7e484 to b2b9cad Compare February 24, 2020 12:45
@rainers
Copy link
Member Author

rainers commented Feb 24, 2020

The tests with mingw are now reduced to druntime unittests and standalone/makefile tests.
Mixing host LDC and dmd test builds is too painful right now for the dmd testsuite, and the phobos unittest executable doesn't link with lld :-/

Copy link
Member

@WalterBright WalterBright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when ready.

when linking through lld-link, add /SAFESEH:NO to linker command line

add build on azure that uses lld and mingw import libraries
use run.d instead of gmake to run tests
d_do_test: remove legacy command line "-map nul.map"
update to build with LDC 1.20.0
@rainers rainers requested a review from ibuclaw as a code owner February 25, 2020 19:58
@rainers rainers changed the base branch from master to stable February 25, 2020 19:58
@rainers
Copy link
Member Author

rainers commented Feb 25, 2020

@wilzbach Azure pipelines are not enabled for stable?

@rainers rainers force-pushed the azure_mingw branch 4 times, most recently from 929e642 to 2bd82c3 Compare February 26, 2020 17:13
@dlang-bot dlang-bot merged commit 5d73251 into dlang:stable Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants