Fix issue 20609 - Disabled and deprecated functions show up as candidate #10838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Geod24
commented
Feb 26, 2020
Geod24
commented
|
Thanks for your pull request, @Geod24! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#10838" |
thewilsonator
approved these changes
Feb 26, 2020
Do not show disabled functions as candidate or hints. Only show deprecated functions when inside a deprecated scope.
Geod24
force-pushed
the
disabled-are-not-candidate
branch
from
5a7dbaf to
fd548dd
Compare
|
Removed test for https://issues.dlang.org/show_bug.cgi?id=19419 because it is now fully covered by this issue. |
|
And the registry is down one more time... |
WalterBright
approved these changes
Feb 29, 2020
|
This is ready for a merge. The Buildkite failure is because |
|
Buildkite fixed (looks like all other agents are down BTW...) and 2 approved reviews, so self auto-merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.