Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 19959 - Eponymous template FQN's re-state the template name #10846

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rainers
Copy link
Member

@rainers rainers commented Feb 27, 2020

2 caveats:

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @rainers!

Bugzilla references

Auto-close Bugzilla Severity Description
19959 enhancement Eponymous template FQN's re-state the template name

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#10846"

if (Dsymbol.oneMembers(ti.members, &sym, ident) && sym is p)
continue;

if (auto td = pparent.isTemplateDeclaration())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the logic is duplicated, I suggest moving the check in a function that receives a ScopeDsymbol (or a template function that receives a template instance or a template declaration) so that we save some lines of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants